Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent create_empty_blocks=false #2284

Merged
merged 2 commits into from
Sep 11, 2018
Merged

Conversation

ValarDragon
Copy link
Contributor

@ValarDragon ValarDragon commented Sep 9, 2018

Closes #1571

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 9, 2018

Codecov Report

Merging #2284 into develop will decrease coverage by 0.05%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #2284      +/-   ##
===========================================
- Coverage    63.87%   63.82%   -0.06%     
===========================================
  Files          140      140              
  Lines         8682     8689       +7     
===========================================
  Hits          5546     5546              
- Misses        2756     2763       +7     
  Partials       380      380

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit 2a49406 into develop Sep 11, 2018
@cwgoes cwgoes deleted the dev/disable_create_empty_blocks branch September 11, 2018 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants