R4R: Change --gas=0 semantic and introduce --gas=simulate #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessio
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
alessio
requested review from
fedekunze,
alexanderbez,
ValarDragon and
jackzampolin
alessio
force-pushed
the
alessio/2300-change-gas-0-semantic
branch
from
6f48ddb
to
6c896df
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2306 +/- ##
===========================================
+ Coverage 63.94% 63.95% +<.01%
===========================================
Files 140 140
Lines 8689 8688 -1
===========================================
Hits 5556 5556
+ Misses 2757 2756 -1
Partials 376 376 |
Make --gas flag accept a conventional "simulate" string value in addition to integers. Passing --gas=simulate would trigger the tx simulation and set the gas according to the gas estimate returned by the simulation. Any other integer value passed to --gas would be interpreted as-is and and set as gas wanted value. Closes: #2300
alessio
force-pushed
the
alessio/2300-change-gas-0-semantic
branch
from
94ab5f9
to
ceba51a
Compare
alessio
changed the title
alessio
changed the title
fedekunze
previously requested changes
Sep 11, 2018
alexanderbez
approved these changes
Sep 11, 2018
|
Appreciated, thanks!
…On Tue, Sep 11, 2018 at 6:59 PM, Dev Ojha ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In client/flags.go
<#2306 (comment)>:
> }
return cmds
}
+
+// Gas flag parsing functions
+
+// GasSetting encapsulates the possible values passed through the --gas flag.
+type GasSetting struct {
+ Simulate bool
+ Gas int64
#2173 <#2173>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2306 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAN_7JTPPZLubTQXq4__HPcO1q5jLn7Fks5uZ_ofgaJpZM4WjHzo>
.
--
Alessio Treglia | alessio@tendermint.com
0416 0004 A827 6E40 BB98 90FB E8A4 8AE5 311D 765A
|
rigelrozanski
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make --gas flag accept a conventional "simulate" string value in addition
to integers. Passing --gas=simulate would trigger the tx simulation and
set the gas according to the gas estimate returned by the simulation.
Any other integer value passed to --gas would be interpreted as-is and
and set as gas wanted value.
Closes: #2300
docs/)PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: