Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: CLI subcommands reorganization #2390

Merged
merged 6 commits into from
Sep 26, 2018
Merged

R4R: CLI subcommands reorganization #2390

merged 6 commits into from
Sep 26, 2018

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Sep 24, 2018

  • Subcommands reorganisation. A comprehensive list of renamings follow:
    - tendermint validator-set -> query tendermint-validator-set
    - tendermint block -> query block
    - account -> query account
    - stake delegation -> query delegation
    - stake delegations -> query delegations
    - stake parameters -> query parameters
    - stake pool -> query pool
    - stake redelegation -> query redelegation
    - stake redelegations -> query redelegations
    - stake signing-info -> query signing-info
    - stake unbonding-delegation -> query unbonding-delegation
    - stake unbonding-delegations -> query unbonding-delegations
    - stake validator -> query validator
    - stake validators -> query validators
    - stake create-validator -> tx create-validator
    - stake edit-validator -> tx edit-validator
    - stake delegate -> tx delegate
    - stake redelegate -> tx redelegate
    - stake unbond -> tx unbond
    - stake unjail -> tx jail
    - gov deposit -> tx deposit
    - gov query-proposal -> query proposal
    - gov query-proposals -> query proposals
    - gov query-vote -> query vote
    - gov query-votes -> query votes
    - gov submit-proposal -> tx submit-proposal
    - gov vote -> tx vote
    - broadcast -> tx broadcast
    - send -> tx send
    - sign -> tx sign
  • Remove unused (and misspelled) SignTxRequstHandler.

Closes: #1184

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 24, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@91cac96). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #2390   +/-   ##
==========================================
  Coverage           ?   64.49%           
==========================================
  Files              ?      138           
  Lines              ?     8619           
  Branches           ?        0           
==========================================
  Hits               ?     5559           
  Misses             ?     2685           
  Partials           ?      375

@alessio alessio changed the title WIP: CLI subcommands reorganization R4R: CLI subcommands reorganization Sep 25, 2018
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Can we add q as a shortcut for query, e.g. gaiacli q redelegation (or is that too much)?

PENDING.md Outdated Show resolved Hide resolved
client/tx/sign.go Show resolved Hide resolved
cmd/gaia/cmd/gaiacli/main.go Outdated Show resolved Hide resolved
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, thanks @alessio

@cwgoes cwgoes merged commit a2caefc into develop Sep 26, 2018
@cwgoes cwgoes deleted the alessio/1184-cli-reorg branch September 26, 2018 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants