Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: [RETRY] Distr-PR-3 More staking hooks #2404

Merged
merged 27 commits into from
Sep 26, 2018
Merged

R4R: [RETRY] Distr-PR-3 More staking hooks #2404

merged 27 commits into from
Sep 26, 2018

Conversation

rigelrozanski
Copy link
Contributor

@rigelrozanski rigelrozanski commented Sep 25, 2018

The previous version of this PR (#2381) was merged into the wrong branch - this is simply a recreation

For distribution PR (ref #2236)
Merge to develop (change base required) after Distr-PR-2 (ref #2379) merged

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests (n/a I think here)

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

Merging #2404 into develop will decrease coverage by 0.05%.
The diff coverage is 46.51%.

@@             Coverage Diff             @@
##           develop    #2404      +/-   ##
===========================================
- Coverage    63.03%   62.97%   -0.06%     
===========================================
  Files          120      121       +1     
  Lines         7234     7271      +37     
===========================================
+ Hits          4560     4579      +19     
- Misses        2360     2374      +14     
- Partials       314      318       +4

@jaekwon jaekwon merged commit b54801b into develop Sep 26, 2018
@rigelrozanski rigelrozanski deleted the rigel/new-hooks branch September 26, 2018 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants