-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Don't lock keys database on read only ops #2544
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessio
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
October 21, 2018 03:21
Codecov Report
@@ Coverage Diff @@
## develop #2544 +/- ##
===========================================
- Coverage 60.28% 60.27% -0.02%
===========================================
Files 150 150
Lines 8589 8591 +2
===========================================
Hits 5178 5178
- Misses 3067 3069 +2
Partials 344 344 |
alessio
force-pushed
the
alessio/load-readonly-dbs
branch
from
October 21, 2018 03:31
9872a28
to
dd84674
Compare
alessio
changed the title
Don't lock keys on read only ops
R4R: Don't lock keys on read only ops
Oct 21, 2018
/cc @jackzampolin |
alessio
changed the title
R4R: Don't lock keys on read only ops
R4R: Don't lock keys database on read only ops
Oct 21, 2018
Do we want to test this with Voyager (cc @faboweb)? |
alexanderbez
approved these changes
Oct 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions and a comment, but otherwise, utACK 👍
alessio
force-pushed
the
alessio/load-readonly-dbs
branch
from
October 22, 2018 16:13
c8bdc58
to
1e8fe86
Compare
alessio
force-pushed
the
alessio/load-readonly-dbs
branch
from
October 22, 2018 16:13
1e8fe86
to
b32c232
Compare
Let's merge this instead: #2489 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverage Tendermint's new
dbm.NewGoLevelDBWithOpts()
call to avoid locking a keys database on read-only operations. This allows pipinggaiacli
commands'sstdout
s andstdin
s.Ref. #966
docs/
)PENDING.md
with issue #Files changed
in the github PR explorerFor Admin Use: