Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Fix DB Write Permissions for gaia keys new #2593

Merged
merged 2 commits into from
Oct 25, 2018

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Oct 24, 2018

  • Use GetKeyBaseWithWritePerm
  • Cleanup user prompt formatting

closes: #2592


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@jackzampolin
Copy link
Member

Good catch here @alexanderbez. Lets get this in the release.

@codecov
Copy link

codecov bot commented Oct 24, 2018

Codecov Report

Merging #2593 into release/v0.25.0 will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release/v0.25.0    #2593   +/-   ##
================================================
  Coverage            58.85%   58.85%           
================================================
  Files                  152      152           
  Lines                 9411     9411           
================================================
  Hits                  5539     5539           
  Misses                3503     3503           
  Partials               369      369

@alessio alessio self-requested a review October 25, 2018 02:42
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uACK

@alessio alessio merged commit ebca085 into release/v0.25.0 Oct 25, 2018
@alessio alessio deleted the bez/fix-keys-new-perm branch October 25, 2018 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI C:Keys Keybase, KMS and HSMs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants