Added generated statik file, otherwise LCD is unusable for apps importing the SDK

[samalba]

I have an app that uses the Cosmos-SDK. I need to add support for LCD, it fails to compile because the generated file statik.go file does not exist in my vendor directory. It's currently generated from the SDK Makefile, which means that all apps vendoring the SDK will miss the file.

I suggest simply adding the statik.go file in the SDK repos so any Cosmos app can enable the LCD support.

[codecov]

Codecov Report

Merging #2673 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2673      +/-   ##
===========================================
+ Coverage     58.7%   58.72%   +0.02%     
===========================================
  Files          152      152              
  Lines         9445     9445              
===========================================
+ Hits          5545     5547       +2     
+ Misses        3530     3528       -2     
  Partials       370      370

[alexanderbez]

@fedekunze Is there a reason we generate this file dynamically or part of the build process? Can we have it as a static file?

[zramsay]

related to #2647 ... they pretty much go together afaict

[fedekunze]

@alexanderbez I guess we can have as a static file. Better ask @HaoyangLiu

[abelliumnt]

@fedekunze If the statik.go is static file, maybe we also need to exclude it from test_lint, besides, the init.go can be removed.

[jackzampolin]

I've recently changed the way the LCD is exposed for clients to register routes. Is this PR still required?

[samalba]

@jackzampolin I don't remember the exact error anymore - IIRC without this you can't import this package without a panic at runtime

[jackzampolin]

@samalba I'm updating our application tutorial now and will see if this is still an issue. You should check out how we are exposing the LCD to app developers now: https://github.com/cosmos/cosmos-sdk/blob/master/cmd/gaia/cmd/gaiacli/main.go#L157-L158

[samalba]

Sounds good, thanks @jackzampolin.

Since the new method RegisterSwaggerUI still uses statik's fs, it will miss the generated data at Runtime without this file: https://github.com/cosmos/cosmos-sdk/blob/master/cmd/gaia/cmd/gaiacli/main.go#L170

I'll simply try with the tutorial, easy to check.

EDIT: I closed the issue by mistake...

[jackzampolin]

@samalba That swagger file only describes the gaia routes. Users would need to write their own swagger file to describe the routes in their app anyway. We need a way to make this more modular.