Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: x/mock/simulation cleanup and re-org #2720

Merged
merged 20 commits into from
Nov 9, 2018
Merged

R4R: x/mock/simulation cleanup and re-org #2720

merged 20 commits into from
Nov 9, 2018

Conversation

rigelrozanski
Copy link
Contributor

@rigelrozanski rigelrozanski commented Nov 7, 2018 •
edited
Loading

NOTE this is rebased on 0.26 so should be merged after that

Due to the form of these changes, I suggest reviewing by just manually going through the commits (which I made many intentionally for this reason) as well as just snooping around x/mock/simulation/

This PR cleans up the simulation module but doesn't change it's functionality. Mostly:

  • lots of whitespace improvements
  • heavy indentation reduction
  • introduction of helper structs, more functionality as properties of these objects
  • heavy function reorg, elimination of grouped types file as per new conventions
  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Nov 7, 2018 •
edited
Loading

Codecov Report

Merging #2720 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2720   +/-   ##
========================================
  Coverage    56.89%   56.89%           
========================================
  Files          155      155           
  Lines         9751     9751           
========================================
  Hits          5548     5548           
  Misses        3825     3825           
  Partials       378      378

@rigelrozanski rigelrozanski changed the title WIP: simulation cleanup/refactor R4R: x/mock/simulation cleanup and re-org Nov 8, 2018
@cwgoes
Copy link
Contributor

cwgoes commented Nov 8, 2018

Thanks @rigelrozanski! I did indeed review commit-by-commit, which was pretty straightforward - LGTM.

Will need to be merged after #2718.

@cwgoes
Copy link
Contributor

cwgoes commented Nov 8, 2018

Also this is going to conflict with #2682 and #2683, so we should either merge those or this first.

@rigelrozanski rigelrozanski mentioned this pull request Nov 8, 2018
Closed
@cwgoes
Copy link
Contributor

cwgoes commented Nov 9, 2018 •
edited
Loading

I'm going to merge this since it has two reviews, doesn't change the state machine, and I need to work on these files.

@cwgoes cwgoes merged commit 1049a26 into develop Nov 9, 2018
@cwgoes cwgoes deleted the rigel/sim-cleanup branch November 9, 2018 15:54
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
@dependabot
chore(deps): Bump docker/build-push-action from 4.1.1 to 4.2.1 (cosmo…
86d11c0 
…s#2720)

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 4.1.1 to 4.2.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/docker/build-push-action/releases">docker/build-push-action's releases</a>.</em></p>
<blockquote>
<h2>v4.2.1</h2>
<blockquote>
<p><strong>Note</strong></p>
<p>Buildx v0.10 enables support for a minimal <a href="https://slsa.dev/provenance/">SLSA Provenance</a> attestation, which requires support for <a href="https://github.com/opencontainers/image-spec">OCI-compliant</a> multi-platform images. This may introduce issues with registry and runtime support (e.g. <a href="https://redirect.github.com/docker/buildx/issues/1533">Google Cloud Run and AWS Lambda</a>). You can optionally disable the default provenance attestation functionality using <code>provenance: false</code>.</p>
</blockquote>
<ul>
<li>warn if docker config can't be parsed by <a href="https://github.com/crazy-max"><code>@​crazy-max</code></a> in <a href="https://redirect.github.com/docker/build-push-action/pull/957">docker/build-push-action#957</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v4.2.0...v4.2.1">https://github.com/docker/build-push-action/compare/v4.2.0...v4.2.1</a></p>
<h2>v4.2.0</h2>
<blockquote>
<p><strong>Note</strong></p>
<p>Buildx v0.10 enables support for a minimal <a href="https://slsa.dev/provenance/">SLSA Provenance</a> attestation, which requires support for <a href="https://github.com/opencontainers/image-spec">OCI-compliant</a> multi-platform images. This may introduce issues with registry and runtime support (e.g. <a href="https://redirect.github.com/docker/buildx/issues/1533">Google Cloud Run and AWS Lambda</a>). You can optionally disable the default provenance attestation functionality using <code>provenance: false</code>.</p>
</blockquote>
<ul>
<li>display proxy configuration  by <a href="https://github.com/crazy-max"><code>@​crazy-max</code></a> in <a href="https://redirect.github.com/docker/build-push-action/pull/872">docker/build-push-action#872</a></li>
<li>chore(deps): Bump <code>@​docker/actions-toolkit</code> from 0.6.0 to 0.8.0 in <a href="https://redirect.github.com/docker/build-push-action/pull/930">docker/build-push-action#930</a></li>
<li>chore(deps): Bump word-wrap from 1.2.3 to 1.2.5 in <a href="https://redirect.github.com/docker/build-push-action/pull/925">docker/build-push-action#925</a></li>
<li>chore(deps): Bump semver from 6.3.0 to 6.3.1 in <a href="https://redirect.github.com/docker/build-push-action/pull/902">docker/build-push-action#902</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v4.1.1...v4.2.0">https://github.com/docker/build-push-action/compare/v4.1.1...v4.2.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/docker/build-push-action/commit/0a97817b6ade9f46837855d676c4cca3a2471fc9"><code>0a97817</code></a> Merge pull request <a href="https://redirect.github.com/docker/build-push-action/issues/957">#957</a> from crazy-max/warn-docker-config</li>
<li><a href="https://github.com/docker/build-push-action/commit/ec39ef320c442d2af669fd8555e7f3b7ad7026bd"><code>ec39ef3</code></a> chore: update generated content</li>
<li><a href="https://github.com/docker/build-push-action/commit/f46044b799d766d2bb3e644bd48da06b6c30a978"><code>f46044b</code></a> warn if docker config can't be parsed</li>
<li><a href="https://github.com/docker/build-push-action/commit/4e4ee680f69700760d5620a94c020aef883043aa"><code>4e4ee68</code></a> Merge pull request <a href="https://redirect.github.com/docker/build-push-action/issues/951">#951</a> from crazy-max/ci-concurrency</li>
<li><a href="https://github.com/docker/build-push-action/commit/e86cf554b69aa5dfd1179937926b6d0cf6550be7"><code>e86cf55</code></a> ci: missing concurrency checks</li>
<li><a href="https://github.com/docker/build-push-action/commit/daa0106f78eed71cdc2a900489ce515acedeef64"><code>daa0106</code></a> Merge pull request <a href="https://redirect.github.com/docker/build-push-action/issues/949">#949</a> from docker/dependabot/github_actions/actions/checkout-4</li>
<li><a href="https://github.com/docker/build-push-action/commit/ce51e905a661fc760fece3d76496f92e48beb8df"><code>ce51e90</code></a> chore(deps): Bump actions/checkout from 3 to 4</li>
<li><a href="https://github.com/docker/build-push-action/commit/1fde16337d494a70a6a0d6c3f24486b201a6a873"><code>1fde163</code></a> Merge pull request <a href="https://redirect.github.com/docker/build-push-action/issues/950">#950</a> from crazy-max/fix-ci</li>
<li><a href="https://github.com/docker/build-push-action/commit/ae311c520f6e620595e7fcb93d4f61d6a5573b5e"><code>ae311c5</code></a> ci: fix workflow</li>
<li><a href="https://github.com/docker/build-push-action/commit/9311bf5263ae5b36f3ec67aff768790c6e2344ad"><code>9311bf5</code></a> Merge pull request <a href="https://redirect.github.com/docker/build-push-action/issues/932">#932</a> from crazy-max/form-templates</li>
<li>Additional commits viewable in <a href="https://github.com/docker/build-push-action/compare/v4.1.1...v4.2.1">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=docker/build-push-action&package-manager=github_actions&previous-version=4.1.1&new-version=4.2.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon left review comments

@alexanderbez alexanderbez alexanderbez left review comments

@cwgoes cwgoes cwgoes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees

@cwgoes cwgoes

Labels
C:Simulations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rigelrozanski @cwgoes @alexanderbez @ValarDragon