R4R: Support export at specific height #2792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2792 +/- ##
===========================================
+ Coverage 56.6% 56.68% +0.07%
===========================================
Files 156 131 -25
Lines 9836 8539 -1297
===========================================
- Hits 5568 4840 -728
+ Misses 3888 3366 -522
+ Partials 380 333 -47 |
cwgoes
changed the title
* Fix Makefile targets dependencies * Remove unnecessary build deps from install targets * Create a rule for each tool * Don't dep test_lint on tools
27 tasks
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
| @@ -13,9 +13,13 @@ import ( | |||
| "path" | |||
| ) | |||
|
|
|||
| const ( | |||
| flagHeight = "height" | |||
There was a problem hiding this comment.
This flag also lives in the client package: https://github.com/cosmos/cosmos-sdk/blob/develop/client/flags.go#L23
There was a problem hiding this comment.
Indeed - I don't know if we want to import the client package from the server package though.
Maybe we should have a common "flags" package.
| @@ -127,6 +127,21 @@ gaiacli status | |||
|
|
|||
| View the status of the network with the [Cosmos Explorer](https://explorecosmos.network). Once your full node syncs up to the current block height, you should see it appear on the [list of full nodes](https://explorecosmos.network/validators). If it doesn't show up, that's ok--the Explorer does not connect to every node. | |||
|
|
|||
| ## Export State | |||
There was a problem hiding this comment.
Likely going to run to a merge conflict here (docs PR)
jackzampolin
approved these changes
Nov 14, 2018
There was a problem hiding this comment.
Pulled this down and was able to make localnet-start, let the network run for a while, export at a height (--height 10), stop the network, gaiad unsafe_reset_all each node, replace the genesis files for each node and restart the network. This gets a 👍 from me!
[R4R] Slight cleanup of distribution specification
* Update docs/sdk/clients.md * organize ADR directory like tendermint * docs: move spec-proposals into spec/ * remove lotion, moved to website repo * move getting-started to cosmos-hub, and voyager to website * docs: move lite/ into clients/lite/ * move introduction/ content to website repo * move resources/ content to website repo * mv sdk/clients.md to clients/clients.md * mv validators to cosmos-hub/validators * move deprecated sdk/ content to _attic * sdk/modules.md is duplicate with modules/README.md * consolidate remianing sdk/ files into a single sdk.md * move examples/ to docs/examples/ * mv docs/cosmos-hub to docs/gaia * Add keys/accounts section to localnet docs
* error checking the API call * added docs build trigger to circleci job
* Update contribuiting.md with new merge policy
jaekwon
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2791
docs/)PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: