Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: add-genesis-account: validate app state accounts #2829

Merged
merged 3 commits into from
Nov 16, 2018

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Nov 15, 2018

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Nov 15, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@9a37066). Click here to learn what that means.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             develop    #2829   +/-   ##
==========================================
  Coverage           ?   56.71%           
==========================================
  Files              ?      131           
  Lines              ?     8544           
  Branches           ?        0           
==========================================
  Hits               ?     4846           
  Misses             ?     3365           
  Partials           ?      333

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Simple, clean and minimal. Although I can see the check getting expensive if there is a ton of accounts?

@alessio
Copy link
Contributor Author

alessio commented Nov 15, 2018

True that @alexanderbez, still this is a command line utility that serves to purpose of preparing genesis.json for further processing by collect-gentxs. Thus I guess performance should not be a big concern here.

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cwgoes cwgoes merged commit bd723fa into develop Nov 16, 2018
@cwgoes cwgoes deleted the alessio/validate-addr-when-adding-genesis-account branch November 16, 2018 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants