Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: gaiad gentx subcommands refactoring #2874

Merged
merged 2 commits into from
Nov 21, 2018
Merged

R4R: gaiad gentx subcommands refactoring #2874

merged 2 commits into from
Nov 21, 2018

Commits on Nov 21, 2018

  1. gaiad gentx subcommands refactoring 

    - Replace STDIN/STDOUT redirection in `gaiad gentx` with subcommands
  command line options to redirect streams to file since viper does
  not handle redirection well.
- Use `BuildCreateValidatorMsg` to build a `MsgCreateValidator` rather
  than redirecting to `gaiacli tx stake create-validator`.
- `PrintUnsignedStdTx` now takes an `io.Writer` object.
- Mark `--pubkey`, `--amount` and `--moniker` as required flags
  instead of validating them manually.
- Use stake.NewDescription() to make a new Description - ref #2835
    Alessio Treglia committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    486f65c View commit details
    Browse the repository at this point in the history

  2. Refresh PENDING.md

    Alessio Treglia committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    3b735bb View commit details
    Browse the repository at this point in the history