Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Update to Tendermint v0.27.0-dev0 #2932

Merged
merged 3 commits into from
Nov 28, 2018
Merged

R4R: Update to Tendermint v0.27.0-dev0 #2932

merged 3 commits into from
Nov 28, 2018

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Nov 28, 2018 •
edited
Loading

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

jackzampolin
jackzampolin approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and runs locally!

ValarDragon
ValarDragon approved these changes Nov 28, 2018
View reviewed changes
Copy link
Contributor

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit aa72e72 into develop Nov 28, 2018
@cwgoes cwgoes deleted the cwgoes/update-to-tendermint-0.27.0-rc0 branch November 28, 2018 22:29
@abelliumnt abelliumnt mentioned this pull request Dec 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackzampolin jackzampolin jackzampolin approved these changes

@ValarDragon ValarDragon ValarDragon approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
C: comet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwgoes @ValarDragon @jackzampolin