-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Fix tag usage in handlers and EndBlocker #2943
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2943 +/- ##
===========================================
- Coverage 56.3% 56.29% -0.02%
===========================================
Files 120 120
Lines 8420 8411 -9
===========================================
- Hits 4741 4735 -6
+ Misses 3357 3354 -3
Partials 322 322 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK; please add a PENDING.md
entry, and we should fix the ability of invalid public keys to halt the state machine (#2945), but that can be done separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
@cwgoes Updated docs and pending 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ❤️
Closes #2941
The tags of the staking EndBlocker have been ignored by now and action tags were added twice for some transactions.
CC @cwgoes - could we get this in for v0.27.0 since this is a blocker for our block explorer?
docs/
)PENDING.md
with issue #Files changed
in the github PR explorerFor Admin Use: