Updates to negative stake fix #3037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwgoes
changed the base branch from
develop
to
jae/removevalidator_negstake_fix
Codecov Report
@@ Coverage Diff @@
## jae/removevalidator_negstake_fix #3037 +/- ##
====================================================================
- Coverage 52.18% 52.16% -0.03%
====================================================================
Files 140 140
Lines 9768 9768
====================================================================
- Hits 5097 5095 -2
- Misses 4330 4332 +2
Partials 341 341 |
| defer proxyApp.Stop() | ||
| defer func() { | ||
| _ = proxyApp.Stop() | ||
| }() |
There was a problem hiding this comment.
confused as to why this is necessary?
There was a problem hiding this comment.
Probably a linting error
There was a problem hiding this comment.
just double checked, it definitely was a linting error (errcheck).
should we not be checking this error still though?
defer func() {
err = proxyApp.Stop()
if err != nil {
panic(err)
}
}()
There was a problem hiding this comment.
I guess not actually because the error is only returned if the proxyApp is already stopped, which wouldn't be an issue in this case
rigelrozanski
approved these changes
Dec 7, 2018
cwgoes
pushed a commit
that referenced
this pull request
Dec 8, 2018
* Fix negative stake & invariance bug * Merge PR #3037: Updates to negative stake fix * Update invariant; fix lint * Fix linter * Add comment & TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jaekwon
For Admin Use: