Fix updateValidatorDistInfoFromPool #3046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaekwon
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #3046 +/- ##
===========================================
+ Coverage 52.16% 52.17% +0.01%
===========================================
Files 140 136 -4
Lines 9768 9605 -163
===========================================
- Hits 5095 5011 -84
+ Misses 4332 4263 -69
+ Partials 341 331 -10 |
|
This was merged because I'm reasonably confident that it's at least better than what we have now on develop, and we might as well bump the rc release. Lets continue discussions and reviews here. |
cwgoes
reviewed
Dec 8, 2018
| if !k.HasValidatorDistInfo(ctx, operatorAddr) { | ||
| return types.ErrNoValidatorDistInfo(k.codespace) | ||
| } | ||
| accAddr := sdk.AccAddress(operatorAddr.Bytes()) | ||
|
|
||
| // withdraw reward for self-delegation |
There was a problem hiding this comment.
Unfortunately, I think this reintroduces the attack we were trying to prevent - #2914
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression introduced by #2984.
Continuiation of #3033 , which didn't fix the simulation issues.
(candidate) Complete solution for #3019, 9002 halt bug.
From #2984, it isn't sufficient to take the fee pool rewards of a validator. Since we don't track delegator accums (as we do with validator accums), and because
onValidatorModified >updateValidatorDistInfoFromPoolis also being called upon delegation updates (or at least I believe this is the reason), it is necessary to also withdraw self delegation.TODO: I don't think self-delegation should be required to be modified here... consider using a delegation hook to do the self-delegation withdraw part instead, e.g. splitting the updateValidatorDistInfoFromPool function into two. It might not result in cleaner code, however. Think hard.