R4R: Implement Proposal Proposer client interfaces #3184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
alexanderbez
requested review from
fedekunze
and removed request for
ebuchman
Codecov Report
@@ Coverage Diff @@
## develop #3184 +/- ##
===========================================
+ Coverage 54.72% 54.76% +0.03%
===========================================
Files 132 132
Lines 9425 9431 +6
===========================================
+ Hits 5158 5165 +7
+ Misses 3949 3948 -1
Partials 318 318 |
alexanderbez
changed the title
jackzampolin
approved these changes
Dec 20, 2018
There was a problem hiding this comment.
This is 🔥 Tested locally and working. Great PR @alexanderbez
|
Great work @alexanderbez, thanks for making LCD that bit more useful :D |
fedekunze
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #3027
/cc @johnmcdowall
I'm not totally thrilled on the solution because it blurs the line of what really belongs in the LCD and what doesn't, as far as querying state is concerned. But maybe this is an exception.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: