Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Allow overriding of CLI transaction response handling #3276

Closed
wants to merge 6 commits into from
Closed

R4R: Allow overriding of CLI transaction response handling #3276

wants to merge 6 commits into from

Commits on Jan 29, 2019

  1. Added ResponseHandler field to CLIContext

    @aaronc
    aaronc committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    64554b6 View commit details
    Browse the repository at this point in the history

  2. Change ResponseHandler -> ResponsePrinter, set to resStr

    @aaronc
    aaronc committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    465c660 View commit details
    Browse the repository at this point in the history

  3. Change ResponsePrinter -> ResponseHandler making the override more ge… 

    …neric
    @aaronc
    aaronc committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    707f364 View commit details
    Browse the repository at this point in the history

  4. Update docstring, cleanup indentation

    @aaronc
    aaronc committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    6e1f27e View commit details
    Browse the repository at this point in the history

  5. Simplified ResponseHandler - no need for it to handle the return valu… 

    …e of broadcastTxCommit
    @aaronc
    aaronc committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    b2410f6 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2019

  1. Renamed ResponseHandler -> TxResponseHandler. Created DefaultTxRespon… 

    …seHandler from body of broadcastTxCommit.
    @aaronc
    aaronc committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    d0006b5 View commit details
    Browse the repository at this point in the history