-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: CLI Response Formatting #3301
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackzampolin
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
January 15, 2019 03:04
4 tasks
Codecov Report
@@ Coverage Diff @@
## develop #3301 +/- ##
===========================================
- Coverage 55.65% 55.04% -0.61%
===========================================
Files 134 134
Lines 9716 9826 +110
===========================================
+ Hits 5407 5409 +2
- Misses 3965 4073 +108
Partials 344 344 |
5 tasks
I tried to bite off too much here. Also there were a large number of PRs merged that will make rebasing this difficult. I've decided to break the CLI output refactor into 3 PRs:
|
Closed in favor of #3320 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Replaces #3275)
Three are currently a number of issues about properly formatting CLI responses:
There are two major issues underlying the above reports:
cliCtx.QueryWithData
return bytes, many places in the cli don't respect--indent
or-o json
because the code isn't thereutils.CompleteAndBroadcastTxCli
don't respect the-o json
or--indent
flags either, and the human readable text format returned is not really readable by humans.The first commit here unifies the
params
calls across the modules. Subsequent commits will generalize the approach for printing developed there to all other query CLI calls. Then the same will be done with the Tx calls. Testing will be added as well.docs/
)PENDING.md
with issue #Files changed
in the github PR explorerFor Admin Use: