Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: reintroduce gaia server's insecure mode #3317

Merged
merged 1 commit into from
Jan 17, 2019
Merged

R4R: reintroduce gaia server's insecure mode #3317

merged 1 commit into from
Jan 17, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jan 17, 2019 •
edited
Loading

Closes: #2715

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #3317 into develop will increase coverage by 0.04%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #3317      +/-   ##
===========================================
+ Coverage    55.62%   55.67%   +0.04%     
===========================================
  Files          132      132              
  Lines         9540     9532       -8     
===========================================
  Hits          5307     5307              
+ Misses        3898     3890       -8     
  Partials       335      335

faboweb
faboweb reviewed Jan 17, 2019
View reviewed changes
Copy link
Contributor

@faboweb faboweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thx @alessio

cwgoes
cwgoes approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

@cwgoes cwgoes merged commit 7fbc282 into develop Jan 17, 2019
@cwgoes cwgoes deleted the alessio/2715-gaia-lite-insecure-mode branch January 17, 2019 13:06
@cwgoes cwgoes mentioned this pull request Jan 17, 2019
Closed
4 tasks
@faboweb
Copy link
Contributor

faboweb commented Jan 18, 2019 •
edited
Loading

@greg-szabo, @mircea-c fiy

@okwme okwme mentioned this pull request Jun 25, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faboweb faboweb faboweb left review comments

@cwgoes cwgoes cwgoes approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@fedekunze fedekunze Awaiting requested review from fedekunze

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio @faboweb @cwgoes