Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Fix validator address encoding in tm validator set command #3504

Merged
merged 2 commits into from
Feb 6, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Feb 5, 2019

  • Use consensus address bech32 prefixing
  • Use CLIContext#PrintOutput

closes: #3501


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

- respect output flag
- add indent flag
- fix Bech32 prefixing for validator address
@jackzampolin
Copy link
Member

Theres a failing LCD test here.

@alexanderbez
Copy link
Contributor Author

@jackzampolin fixed

@codecov
Copy link

codecov bot commented Feb 6, 2019

Codecov Report

Merging #3504 into develop will decrease coverage by 1.91%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3504      +/-   ##
===========================================
- Coverage    54.89%   52.97%   -1.92%     
===========================================
  Files          141      142       +1     
  Lines        10426    10363      -63     
===========================================
- Hits          5723     5490     -233     
- Misses        4357     4550     +193     
+ Partials       346      323      -23

@cwgoes cwgoes merged commit 7173164 into develop Feb 6, 2019
@cwgoes cwgoes deleted the bez/3501-fix-val-address-bech32 branch February 6, 2019 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/validatorsets/{height} endpoint returns incorrect address
4 participants