-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: CLI support for showing bech32 addresses in Ledger devices #3670
Conversation
view bech32
feature in Ledger deviceskeys show ledger_addr -d
feature in Ledger devices
keys show ledger_addr -d
feature in Ledger devicesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @jleni -- I left a few minor comments. I'll also want to play with this a bit too prior to merging 👍
Yes, definitely! Feedback specific to the app is going to this issue here: cosmos/ledger-cosmos#101 |
All items in the review have been considered or issues have been opened. |
@jleni do you mind fixing merge conflicts here? Also lets get this cherrypicked into 0.32.1 |
Co-Authored-By: jleni <juan.leni@zondax.ch>
315441d
to
5e2bed2
Compare
5e2bed2
to
cf9c4c1
Compare
Any updates on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
This PR closes #3658
It requires unreleased Ledger app Cosmos v1.1.0
docs/
)PENDING.md
with issue #Files changed
in the github PR explorerFor Admin Use: