Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Rigel/safe coins #3687

Closed
wants to merge 18 commits into from
Closed

Conversation

rigelrozanski
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@rigelrozanski rigelrozanski changed the base branch from rigel/consistent-operators to alessio/safe-coins February 19, 2019 20:57
@rigelrozanski rigelrozanski mentioned this pull request Feb 19, 2019
5 tasks
@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (alessio/safe-coins@6e34853). Click here to learn what that means.
The diff coverage is 85.81%.

@@                  Coverage Diff                  @@
##             alessio/safe-coins    #3687   +/-   ##
=====================================================
  Coverage                      ?   61.21%           
=====================================================
  Files                         ?      190           
  Lines                         ?    13994           
  Branches                      ?        0           
=====================================================
  Hits                          ?     8567           
  Misses                        ?     4891           
  Partials                      ?      536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants