Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: lcd test unexpected slashing in TestBonding #3710

Merged
merged 5 commits into from
Feb 22, 2019
Merged

Conversation

rigelrozanski
Copy link
Contributor

@rigelrozanski rigelrozanski commented Feb 22, 2019

closes #3559

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #3710 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3710      +/-   ##
===========================================
- Coverage    61.18%   61.15%   -0.03%     
===========================================
  Files          190      190              
  Lines        14008    14008              
===========================================
- Hits          8571     8567       -4     
- Misses        4901     4905       +4     
  Partials       536      536

@rigelrozanski rigelrozanski changed the title WIP: lcd test unexpected slashing in TestBonding R4R: lcd test unexpected slashing in TestBonding Feb 22, 2019
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, excellent catch, makes sense

@cwgoes cwgoes merged commit b823203 into develop Feb 22, 2019
@cwgoes cwgoes deleted the rigel/303030 branch February 22, 2019 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-Deterministic Bonding Test
3 participants