Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Remove Height Flag from CLI Queries #3883 #3910

Merged
merged 2 commits into from
Mar 16, 2019
Merged

R4R: Remove Height Flag from CLI Queries #3883 #3910

merged 2 commits into from
Mar 16, 2019

Conversation

yangyanqing
Copy link
Contributor

@yangyanqing yangyanqing commented Mar 15, 2019

close: #3883

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yangyanqing
Copy link
Contributor Author

I just remove the flag --height, and still need to check the commands and documents one by one.

@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #3910 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3910      +/-   ##
===========================================
- Coverage    60.25%   60.24%   -0.01%     
===========================================
  Files          195      195              
  Lines        14599    14598       -1     
===========================================
- Hits          8796     8794       -2     
- Misses        5218     5219       +1     
  Partials       585      585

@yangyanqing yangyanqing changed the title WIP: Remove Height Flag from CLI Queries #3883 R4R: Remove Height Flag from CLI Queries #3883 Mar 15, 2019
@yangyanqing
Copy link
Contributor Author

Flag --height has not been implemented yet. I have removed the description from document.

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yangyanqing

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Merging, thanks.

@alessio alessio merged commit 3d2886d into cosmos:develop Mar 16, 2019
@yangyanqing yangyanqing deleted the frank/issue-3883-remove-height-flag branch March 16, 2019 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Height Flag from CLI Queries
3 participants