Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix queryDelegatorTotalRewards #4078

Merged
merged 5 commits into from
Apr 10, 2019
Merged

Fix queryDelegatorTotalRewards #4078

merged 5 commits into from
Apr 10, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Apr 9, 2019

Return [] instead of null by making the initial value an empty slice literal opposed to nil.

closes: #3705


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added WIP C:x/distribution distribution module related labels Apr 9, 2019
@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #4078 into develop will decrease coverage by 0.02%.
The diff coverage is 11.11%.

@@             Coverage Diff             @@
##           develop    #4078      +/-   ##
===========================================
- Coverage    59.98%   59.96%   -0.03%     
===========================================
  Files          212      212              
  Lines        15123    15123              
===========================================
- Hits          9072     9068       -4     
- Misses        5431     5435       +4     
  Partials       620      620

@alexanderbez alexanderbez marked this pull request as ready for review April 9, 2019 14:27
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alessio alessio merged commit 94b7d8f into develop Apr 10, 2019
@alessio alessio deleted the bez/3705-rewards-bugs branch April 10, 2019 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/distribution distribution module related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

empty rewards returns null
3 participants