R4R [Staging PR 2/3] genesis generalization #4128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigelrozanski
requested review from
alessio,
alexanderbez and
jackzampolin
as code owners
golangcibot
reviewed
Apr 17, 2019
cmd/gaia/app/app.go
Outdated
| var moduleBasics []sdk.AppModuleBasics | ||
|
|
||
| func init() { | ||
| moduleBasics := []sdk.AppModuleBasics{ |
There was a problem hiding this comment.
ineffectual assignment to moduleBasics (from ineffassign)
There was a problem hiding this comment.
Good to know that this thing actually works :)
Codecov Report
@@ Coverage Diff @@
## rigel/genesis-generalization #4128 +/- ##
===============================================================
Coverage ? 59.03%
===============================================================
Files ? 222
Lines ? 15351
Branches ? 0
===============================================================
Hits ? 9062
Misses ? 5672
Partials ? 617 |
rigelrozanski
changed the title
5 tasks
rigelrozanski
changed the title
fedekunze
reviewed
Apr 23, 2019
| func (a AppModule) InitGenesis(ctx sdk.Context, data json.RawMessage) []abci.ValidatorUpdate { | ||
| var genesisState GenesisState | ||
| moduleCdc.MustUnmarshalJSON(data, &genesisState) | ||
| InitGenesis(ctx, a.accountKeeper, a.feeCollectionKeeper, genesisState) |
There was a problem hiding this comment.
Suggested change
| InitGenesis(ctx, a.accountKeeper, a.feeCollectionKeeper, genesisState) | |
| InitGenesis(ctx, appModule.accountKeeper, appModule.feeCollectionKeeper, genesisState) |
There was a problem hiding this comment.
see first comment
| } | ||
|
|
||
| // module export genesis | ||
| func (a AppModule) ExportGenesis(ctx sdk.Context) json.RawMessage { |
There was a problem hiding this comment.
Suggested change
| func (a AppModule) ExportGenesis(ctx sdk.Context) json.RawMessage { | |
| func (appModule AppModule) ExportGenesis(ctx sdk.Context) json.RawMessage { |
There was a problem hiding this comment.
see first comment
|
|
||
| // module export genesis | ||
| func (a AppModule) ExportGenesis(ctx sdk.Context) json.RawMessage { | ||
| gs := ExportGenesis(ctx, a.accountKeeper, a.feeCollectionKeeper) |
There was a problem hiding this comment.
Suggested change
| gs := ExportGenesis(ctx, a.accountKeeper, a.feeCollectionKeeper) | |
| gs := ExportGenesis(ctx, appModule.accountKeeper, appModule.feeCollectionKeeper) |
There was a problem hiding this comment.
see first comment
|
|
||
| // module export genesis | ||
| func (a AppModule) ExportGenesis(ctx sdk.Context) json.RawMessage { | ||
| gs := ExportGenesis(ctx, a.keeper) |
There was a problem hiding this comment.
Suggested change
| gs := ExportGenesis(ctx, a.keeper) | |
| gs := ExportGenesis(ctx, appModule.keeper) |
There was a problem hiding this comment.
see first comment
| var genesisState GenesisState | ||
| moduleCdc.MustUnmarshalJSON(data, &genesisState) | ||
| InitGenesis(ctx, a.keeper, genesisState) | ||
|
|
||
| a.keeper.AssertInvariants(ctx, a.logger) |
There was a problem hiding this comment.
Suggested change
| a.keeper.AssertInvariants(ctx, a.logger) | |
| appModule.keeper.AssertInvariants(ctx, appModule.logger) |
There was a problem hiding this comment.
see first comment
|
|
||
| // module export genesis | ||
| func (a AppModule) ExportGenesis(ctx sdk.Context) json.RawMessage { | ||
| gs := ExportGenesis(ctx, a.keeper) |
There was a problem hiding this comment.
Suggested change
| gs := ExportGenesis(ctx, a.keeper) | |
| gs := ExportGenesis(ctx, appModule.keeper) |
5 tasks
alexanderbez
added
the
T: State Machine Breaking
|
closing in favour of #4159 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging PR
Downstream #4033
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: