Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow tx send (generate-only) to actually work offline #4234

Merged
merged 2 commits into from
Apr 30, 2019
Merged

Allow tx send (generate-only) to actually work offline #4234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abb2227
Allow tx send (generate-only) to actually work offline
alexanderbez Apr 30, 2019
f8527d4
Add pending log entry
alexanderbez Apr 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .pending/bugfixes/sdk/4234-https-github-co
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[#4234](https://github.com/cosmos/cosmos-sdk/pull/4234) Allow `tx send --generate-only` to
actually work offline.
4 changes: 0 additions & 4 deletions x/bank/client/cli/sendtx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@ func SendTxCmd(cdc *codec.Codec) *cobra.Command {
WithCodec(cdc).
WithAccountDecoder(cdc)

if err := cliCtx.EnsureAccountExists(); err != nil {
return err
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should disable this test only when generate mode is on (and leave it otherwise)?

Copy link
Contributor Author

@alexanderbez alexanderbez Apr 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, but no need to. No other command work like this. When you omit --generate-only, EnsureAccountExists does get called. So having it here was wrong and superfluous.


to, err := sdk.AccAddressFromBech32(args[1])
if err != nil {
return err
Expand Down