Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.34.5 - RC2 #4412

Merged
merged 1 commit into from
May 24, 2019
Merged

Release v0.34.5 - RC2 #4412

merged 1 commit into from
May 24, 2019

Conversation

alexanderbez
Copy link
Contributor

Cherry picked non-breaking the following PRs which already exist on master:


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #4412 into rc1/v0.34.5 will decrease coverage by 0.68%.
The diff coverage is 44.44%.

@@              Coverage Diff               @@
##           rc1/v0.34.5   #4412      +/-   ##
==============================================
- Coverage        60.09%   59.4%   -0.69%     
==============================================
  Files              212     214       +2     
  Lines            15222   15418     +196     
==============================================
+ Hits              9147    9159      +12     
- Misses            5442    5624     +182     
- Partials           633     635       +2

@jackzampolin jackzampolin merged this pull request into rc1/v0.34.5 May 24, 2019
@alexanderbez alexanderbez deleted the rc2/v0.34.5 branch May 24, 2019 20:53
@alexanderbez alexanderbez restored the rc2/v0.34.5 branch May 24, 2019 20:53
@alexanderbez alexanderbez deleted the rc2/v0.34.5 branch May 24, 2019 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants