Improve coverage via optimized seeds #4504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improving coverage by adding four seeds that have been optimized for it.
npinto
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
npinto
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4504 +/- ##
==========================================
- Coverage 53.18% 53.16% -0.02%
==========================================
Files 259 259
Lines 16190 16190
==========================================
- Hits 8610 8608 -2
- Misses 6934 6936 +2
Partials 646 646 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #4504 +/- ##
==========================================
- Coverage 53.18% 53.16% -0.02%
==========================================
Files 259 259
Lines 16190 16190
==========================================
- Hits 8610 8608 -2
- Misses 6934 6936 +2
Partials 646 646 |
|
Is the coverage report produced by codecov including coverage from the sim (e.g. |
|
@npinto no, I do not believe so. Is this ready for review? |
|
Yes, it is ready for review :-) What would we need to see codecov report the improve coverage? I can post the intermediate results of my experiments to show increase coverage if needed.
Thanks!
… On Jun 6, 2019, at 13:31, Alexander Bezobchuk ***@***.***> wrote:
@npinto no, I do not believe so. Is this ready for review?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@npinto yes please share your results. With regards to code coverage, since it's ran via |
alexanderbez
changed the title
alessio
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving coverage by adding seeds that have been optimized for it.
For Admin Use: