Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for n00bs #47

Merged
merged 3 commits into from
Mar 3, 2017
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@ and away you go with a full-stack blockchain and command line tool for transacti

WARNING: Currently uses plain-text private keys for transactions and is otherwise not production ready.

## Prerequisites

* Go to https://golang.org/doc/install to install Golang.
* Once you have Golang installed you will also need to install the Golang package manager `glide`: https://github.com/Masterminds/glide.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is somewhat optional (if go get fails or the dev wants fixed versions)

Copy link
Contributor Author

@hcopperm hcopperm Mar 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go get succeeded but i wasn't able to run make get_vendor_deps without glide, i got this error:

/go/src/github.com/tendermint/basecoin (develop) $ make get_vendor_deps
go get github.com/Masterminds/glide
glide install
make: glide: No such file or directory
make: *** [get_vendor_deps] Error 1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no need to make get_vendor_deps if go get -u .../cmd/basecoin succeeded.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in that case I think we need to change the instructions here:

The guaranteed correct way of compiling from source, assuming you've already run go get or otherwise cloned the repo, is:

git checkout develop # (until we release tendermint v0.9)
make get_vendor_deps
make install

because it seems like once you do go get you're supposed to do all that stuff ^^. How would you change it?

* You will also need to set the $GOPATH environment variable as per the instructions [here](https://golang.org/doc/code.html#GOPATH).

## Installation

On a good day, basecoin can be installed like a normal Go program:
Expand Down