update x/genutil to match module spec #4757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
fedekunze
added
Type: Code Hygiene
fedekunze
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4757 +/- ##
==========================================
+ Coverage 53.87% 53.89% +0.01%
==========================================
Files 270 270
Lines 17230 17229 -1
==========================================
+ Hits 9283 9285 +2
+ Misses 7263 7260 -3
Partials 684 684 |
fedekunze
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
fedekunze
commented
Jul 23, 2019
colin-axner
suggested changes
Jul 23, 2019
colin-axner
approved these changes
Jul 23, 2019
alexanderbez
approved these changes
Jul 23, 2019
| // ModuleCdc defines a generic sealed codec to be used throughout this module | ||
| var ModuleCdc *codec.Codec | ||
|
|
||
| // TODO: abstract genesis transactions registration back to staking |
There was a problem hiding this comment.
Please make an issue for this if one does not already exist :)
| @@ -0,0 +1,41 @@ | |||
| package types | |||
There was a problem hiding this comment.
Why is this worthy of having to be under a specific directory?
There was a problem hiding this comment.
this file? or the types package as as a whole
There was a problem hiding this comment.
I think it is, these are type definitions here, might as well add them to remain consistent with our file organization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4751
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: