Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CheckTx msg routing #4810

Merged
merged 5 commits into from
Jul 30, 2019
Merged

CheckTx msg routing #4810

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9f7fdfb
remove tx mode check from baseapp
fedekunze Jul 30, 2019
ae1e39f
clog
fedekunze Jul 30, 2019
9004402
Update .pending/bugfixes/abci/_4639-checktx-verify
alexanderbez Jul 30, 2019
a9743d0
Merge branch 'master' into fedekunze/4639-checktx-msg-routing
alexanderbez Jul 30, 2019
c26773c
Add safety check
alexanderbez Jul 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pending/bugfixes/abci/_4639-checktx-verify
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#4639 Fix `CheckTx` by verifying the message route
9 changes: 2 additions & 7 deletions baseapp/baseapp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,9 +632,8 @@ func (app *BaseApp) BeginBlock(req abci.RequestBeginBlock) (res abci.ResponseBeg
}

// CheckTx implements the ABCI interface. It runs the "basic checks" to see
// whether or not a transaction can possibly be executed, first decoding, then
// the ante handler (which checks signatures/fees/ValidateBasic), then finally
// the route match to see whether a handler exists.
// whether or not a transaction can possibly be executed, first decoding and then
// the ante handler (which checks signatures/fees/ValidateBasic).
//
// NOTE:CheckTx does not run the actual Msg handler function(s).
func (app *BaseApp) CheckTx(req abci.RequestCheckTx) (res abci.ResponseCheckTx) {
Expand Down Expand Up @@ -906,10 +905,6 @@ func (app *BaseApp) runTx(mode runTxMode, txBytes []byte, tx sdk.Tx) (result sdk
msCache.Write()
}

if mode == runTxModeCheck {
return result
}

// Create a new context based off of the existing context with a cache wrapped
// multi-store in case message processing fails.
runMsgCtx, msCache := app.cacheTxContext(ctx, txBytes)
Expand Down