Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix DefaultUnbondingTime #4823

Merged
merged 4 commits into from
Jul 31, 2019
Merged

fix DefaultUnbondingTime #4823

merged 4 commits into from
Jul 31, 2019

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Jul 31, 2019 •
edited by alexanderbez
Loading

replaces #4712

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze mentioned this pull request Jul 31, 2019
Closed
@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #4823 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4823   +/-   ##
=======================================
  Coverage   50.42%   50.42%           
=======================================
  Files         288      288           
  Lines       18528    18528           
=======================================
  Hits         9342     9342           
  Misses       8501     8501           
  Partials      685      685

alexanderbez
alexanderbez approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit 0fec748 into master Jul 31, 2019
@alexanderbez alexanderbez deleted the fedekunze/fix-defaultubd-time branch July 31, 2019 14:46
alexanderbez pushed a commit that referenced this pull request Jul 31, 2019
@fedekunze @alexanderbez
Merge PR #4823: fix DefaultUnbondingTime
2561490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio Awaiting requested review from alessio

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedekunze @alexanderbez