Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent community spend proposal from transferring funds to a ModuleAcc #4831

Merged
merged 2 commits into from
Aug 2, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pending/bugfixes/modules/_prevent-community-s
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Prevent community spend proposal from transfering funds to a module account
fedekunze marked this conversation as resolved.
Show resolved Hide resolved
4 changes: 4 additions & 0 deletions x/distribution/keeper/proposal_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ import (

// HandleCommunityPoolSpendProposal is a handler for executing a passed community spend proposal
func HandleCommunityPoolSpendProposal(ctx sdk.Context, k Keeper, p types.CommunityPoolSpendProposal) sdk.Error {
if k.blacklistedAddrs[p.Recipient.String()] {
return sdk.ErrUnauthorized(fmt.Sprintf("%s is blacklisted from receiving external funds", p.Recipient))
}

err := k.DistributeFromFeePool(ctx, p.Amount, p.Recipient)
if err != nil {
return err
Expand Down