Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation Fixes #4861

Merged
merged 5 commits into from
Aug 7, 2019
Merged

Simulation Fixes #4861

merged 5 commits into from
Aug 7, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Aug 7, 2019

  • Fix the broken test_sim_nondeterminism make target (I'm scared to know how long this was broken for)
  • Fix TestAppStateDeterminism to use CLI input params
  • Fix SimulateFromSeed to actually panic (returns non-zero exit code)
  • Some general cleanup

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #4861 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4861      +/-   ##
==========================================
+ Coverage    54.3%   54.31%   +0.01%     
==========================================
  Files         271      271              
  Lines       17344    17344              
==========================================
+ Hits         9418     9420       +2     
+ Misses       7228     7226       -2     
  Partials      698      698

@alexanderbez alexanderbez changed the title Fix non-determinism sim Simulation Fixes Aug 7, 2019
@alexanderbez alexanderbez added R4R and removed WIP labels Aug 7, 2019
@alexanderbez alexanderbez marked this pull request as ready for review August 7, 2019 15:30
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Pending bugfix pending entry

@alexanderbez alexanderbez merged commit 42c54f8 into master Aug 7, 2019
@alexanderbez alexanderbez deleted the bez/fix-non-determinism-sim branch August 7, 2019 16:54
alexanderbez added a commit that referenced this pull request Aug 8, 2019
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants