R4R Add security contact to Validator description #4865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigelrozanski
requested review from
alessio,
alexanderbez,
fedekunze and
jackzampolin
as code owners
rigelrozanski
changed the title
rigelrozanski
changed the title
fedekunze
suggested changes
Aug 8, 2019
alexanderbez
suggested changes
Aug 8, 2019
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #4865 +/- ##
==========================================
- Coverage 54.05% 54.03% -0.03%
==========================================
Files 269 269
Lines 17116 17130 +14
==========================================
+ Hits 9252 9256 +4
- Misses 7178 7186 +8
- Partials 686 688 +2 |
|
do we also need to add the genesis migration file? |
|
@fedekunze not sure, but I don't think we need to specify between email and phone... I doubt anyone will put their phone. |
alexanderbez
suggested changes
Aug 11, 2019
|
Olright I added some migration details to the staking package however I haven't included a migration command upgrade to the genutil CLI command yet - that should occur in a separate PR, I was going to do it here but I realized I think there may be an abstraction that we could implement to avoid dup. code in |
fedekunze
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4814
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [-t <tag>] [-m <msg>]Re-reviewed
Files changedin the github PR explorerFor Admin Use: