-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IAVL Store Commit #4880
Fix IAVL Store Commit #4880
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4880 +/- ##
=======================================
Coverage 54.05% 54.05%
=======================================
Files 269 269
Lines 17116 17116
=======================================
Hits 9252 9252
Misses 7178 7178
Partials 686 686 |
I think it is best to keep the same logic (and add a test). You rightly noted that this broke as the iavl error format changes: if _, ok := tree.versions[version]; !ok {
return errors.Wrap(ErrVersionDoesNotExist, "")
} https://github.com/tendermint/iavl/blob/master/mutable_tree.go#L436-L438 This can be detected (safely) with I would propose simply changing the original line: That seems the cleaner fix (and maybe a test there) |
MutableTree#DeleteVersion
only returns standard errors now.Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
clog add [section] [-t <tag>] [-m <msg>]
Re-reviewed
Files changed
in the github PR explorerFor Admin Use: