Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaiacli should not panic when user just presses enter during Y/n confirmation #4919

Merged
merged 2 commits into from
Aug 19, 2019
Merged

Conversation

haasted
Copy link
Contributor

@haasted haasted commented Aug 17, 2019

Addressing the issue encountered here: e-money/em-ledger#1

If the user does not enter a character in response to the CLI query confirm transaction before signing and broadcasting [y/N]: gaiacli will crash with a panic.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the github PR explorer

@codecov
Copy link

codecov bot commented Aug 17, 2019

Codecov Report

Merging #4919 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4919      +/-   ##
==========================================
+ Coverage   53.67%   53.68%   +0.01%     
==========================================
  Files         272      272              
  Lines       17052    17052              
==========================================
+ Hits         9152     9154       +2     
+ Misses       7210     7208       -2     
  Partials      690      690

1 similar comment
@codecov
Copy link

codecov bot commented Aug 17, 2019

Codecov Report

Merging #4919 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4919      +/-   ##
==========================================
+ Coverage   53.67%   53.68%   +0.01%     
==========================================
  Files         272      272              
  Lines       17052    17052              
==========================================
+ Hits         9152     9154       +2     
+ Misses       7210     7208       -2     
  Partials      690      690

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Please add a bugfix entry on the changelog.md

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK -- thanks @haasted :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants