Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gov query vote cmd #4932

Merged
merged 4 commits into from
Aug 20, 2019
Merged

Fix gov query vote cmd #4932

merged 4 commits into from
Aug 20, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Aug 20, 2019

closes: #4927


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #4932 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4932      +/-   ##
==========================================
+ Coverage   53.74%   53.75%   +0.01%     
==========================================
  Files         272      272              
  Lines       17103    17103              
==========================================
+ Hits         9192     9194       +2     
+ Misses       7224     7222       -2     
  Partials      687      687

@alexanderbez alexanderbez merged commit 1f04826 into master Aug 20, 2019
@alexanderbez alexanderbez deleted the bez/4927-fix-gov-query-vote-cmd branch August 20, 2019 16:57
alexanderbez added a commit that referenced this pull request Aug 20, 2019
@tnachen
Copy link
Contributor

tnachen commented Aug 20, 2019

Will this mask any other error that we actually want to catch?

@alexanderbez
Copy link
Contributor Author

Will this mask any other error that we actually want to catch?

No it will not @tnachen. This is unique to this particular flow since we prune votes after voting period is over.

@alexanderbez alexanderbez mentioned this pull request Aug 21, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query proposal lcd endpoint not working
3 participants