Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all the empty arrays return an empty slice #5248

Merged
merged 8 commits into from
Oct 28, 2019
Merged

Ensure all the empty arrays return an empty slice #5248

merged 8 commits into from
Oct 28, 2019

Conversation

RiccardoM
Copy link
Contributor

Description

Works towards #4741

Checklist

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Thanks, forgot about it!

Co-Authored-By: Alessio Treglia <quadrispro@ubuntu.com>
@codecov
Copy link

codecov bot commented Oct 25, 2019

Codecov Report

Merging #5248 into master will decrease coverage by 0.04%.
The diff coverage is 38.88%.

@@            Coverage Diff            @@
##           master   #5248      +/-   ##
=========================================
- Coverage   53.54%   53.5%   -0.05%     
=========================================
  Files         290     290              
  Lines       17738   17770      +32     
=========================================
+ Hits         9497    9507      +10     
- Misses       7502    7513      +11     
- Partials      739     750      +11

RiccardoM and others added 2 commits October 25, 2019 21:54
Co-Authored-By: Alessio Treglia <quadrispro@ubuntu.com>
Co-Authored-By: Alessio Treglia <quadrispro@ubuntu.com>
Co-Authored-By: Alessio Treglia <quadrispro@ubuntu.com>
@alessio
Copy link
Contributor

alessio commented Oct 25, 2019

This should be marked as an API/ABI breaking change due to the changes in publicly exported functions return values

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RiccardoM! Looks good apart from one change.

x/staking/keeper/querier.go Outdated Show resolved Hide resolved
@alexanderbez alexanderbez added Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. R4R labels Oct 27, 2019
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 🎉

@alexanderbez alexanderbez merged commit 5af6bd7 into cosmos:master Oct 28, 2019
@RiccardoM RiccardoM mentioned this pull request Nov 13, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants