-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure all the empty arrays return an empty slice #5248
Ensure all the empty arrays return an empty slice #5248
Conversation
Thanks, forgot about it! Co-Authored-By: Alessio Treglia <quadrispro@ubuntu.com>
Codecov Report
@@ Coverage Diff @@
## master #5248 +/- ##
=========================================
- Coverage 53.54% 53.5% -0.05%
=========================================
Files 290 290
Lines 17738 17770 +32
=========================================
+ Hits 9497 9507 +10
- Misses 7502 7513 +11
- Partials 739 750 +11 |
Co-Authored-By: Alessio Treglia <quadrispro@ubuntu.com>
Co-Authored-By: Alessio Treglia <quadrispro@ubuntu.com>
Co-Authored-By: Alessio Treglia <quadrispro@ubuntu.com>
This should be marked as an API/ABI breaking change due to the changes in publicly exported functions return values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RiccardoM! Looks good apart from one change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 🎉
Description
Works towards #4741
Checklist
docs/
)Unreleased
section inCHANGELOG.md
Files changed
in the github PR explorerFor Admin Use: