Pass in sdk.Context to router.Route()

[sunnya97]

Adding this will allow apps to create more customizable msg Routers. For example, this one I wrote here that allows governance to toggle on and off certain routes.

For a router, that doesn't want to make use of the ctx (like the default one in baseapp), it can just ignore it.

closes: #5455

---

For contributor use:

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer

---

For admin use:

• Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• Reviewers assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[alexanderbez]

Mhhhh, something about routers being stateful doesn't sit right with me. Is the point to disable certain message routes? Typically, this is done via parameters but that's not the best UX, I agree. There is also this issue on Hierarchical Msg Routing, which I think has some overlap here.

Would like to get other opinions here @AdityaSripal @fedekunze

[sunnya97]

@alexanderbez Is the point to disable certain message routes?

Well, that's one example, which I wrote a module for. There are probably other reasons to do it as well such as upgrading a specific module (assuming modules are hot-loaded using CosmWasm or something).

Typically, this is done via parameters but that's not the best UX, I agree.

Also, genesis parameters can't be changed. I want governance to be able to update on an active chain. I do use the paramstore in the togglerouter module, but the router needs the ctx in order to get the current state of the params. We'll also need something like this for the circuit breaker.

[alexanderbez]

ref: #5455 (comment)

I don't have any strong objections here. Concept ACK unless others can state strong objective reasons for not going forward.

[alexanderbez]

small nit, otherwise ACK.

[alexanderbez]

ACK

[fedekunze]

ACK

[codecov]

Codecov Report

Merging #5452 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5452      +/-   ##
==========================================
+ Coverage    54.4%   54.42%   +0.02%     
==========================================
  Files         313      313              
  Lines       18850    18854       +4     
==========================================
+ Hits        10255    10261       +6     
+ Misses       7808     7806       -2     
  Partials      787      787

Impacted Files	Coverage Δ
baseapp/router.go	100% <100%> (ø)	⬆️
baseapp/baseapp.go	71.37% <100%> (ø)	⬆️
baseapp/options.go	73.13% <100%> (+1.7%)	⬆️
x/mock/app.go	64.18% <0%> (+1.35%)	⬆️