Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proto: migrate x/distr to use hybrid codec #5610

Merged
merged 54 commits into from
Feb 11, 2020
Merged

proto: migrate x/distr to use hybrid codec #5610

merged 54 commits into from
Feb 11, 2020

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Feb 4, 2020 •
edited by alexanderbez
Loading

migration of distr to hybrid codec

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

alexanderbez and others added 17 commits February 1, 2020 14:34
@tac0turtle tac0turtle added WIP C:x/distribution distribution module related T: State Machine Breaking State machine breaking changes (impacts consensus). labels Feb 4, 2020
@tac0turtle tac0turtle self-assigned this Feb 4, 2020
@tac0turtle tac0turtle added R4R and removed WIP labels Feb 7, 2020
alexanderbez
alexanderbez suggested changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks @marbar3778. I left some minor feedback :)

CHANGELOG.md Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
x/distribution/client/cli/query.go Outdated Show resolved Hide resolved
x/distribution/client/cli/query.go Outdated Show resolved Hide resolved
x/distribution/keeper/delegation.go Outdated Show resolved Hide resolved
x/distribution/keeper/hooks.go Outdated Show resolved Hide resolved
x/distribution/keeper/invariants.go Outdated Show resolved Hide resolved
x/distribution/keeper/store.go Outdated Show resolved Hide resolved
x/distribution/types/delegator.go Show resolved Hide resolved
tac0turtle
tac0turtle commented Feb 11, 2020
View reviewed changes
third_party/proto/tendermint/abci/types/types.proto
@@ -60,11 +62,10 @@ message RequestSetOption {
}

message RequestInitChain {
google.protobuf.Timestamp time = 1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed a lot of these here: tendermint/tendermint#4386 this will be in the next release. The release will be coming in the coming days

alexanderbez
alexanderbez suggested changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

alexanderbez
alexanderbez approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez mentioned this pull request Feb 11, 2020
Closed
28 tasks
@alexanderbez alexanderbez merged commit 56c5868 into master Feb 11, 2020
@alexanderbez alexanderbez deleted the proto/distr branch February 11, 2020 14:58
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@tac0turtle
Merge PR cosmos#5610: proto: migrate x/distr to use hybrid codec
918abee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio Awaiting requested review from alessio

@fedekunze fedekunze Awaiting requested review from fedekunze

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees

@tac0turtle tac0turtle

Labels
C:x/distribution distribution module related T: State Machine Breaking State machine breaking changes (impacts consensus).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tac0turtle @alexanderbez