-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto/keys: move keybase and keyring to crypto/keyring/ dir #5866
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant! Even package names now make sense!
Codecov Report
@@ Coverage Diff @@
## master #5866 +/- ##
==========================================
- Coverage 32.32% 32.27% -0.05%
==========================================
Files 353 355 +2
Lines 39476 39447 -29
==========================================
- Hits 12760 12731 -29
Misses 25440 25440
Partials 1276 1276
|
…cosmos-sdk into fedekunze/5819-move-keys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (assuming no changes to business logic).
Please fix |
Description
re: #5819
Moves the keyring and keybase types to a
keyring/
directory. Tendermint key types will follow in a later PRFor contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)