-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/evidence: StoreDecoder simulation #6035
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6035 +/- ##
==========================================
- Coverage 54.66% 54.64% -0.02%
==========================================
Files 425 426 +1
Lines 25866 25890 +24
==========================================
+ Hits 14139 14148 +9
- Misses 10750 10763 +13
- Partials 977 979 +2 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could simulate a bit more precisely, and are there any other evidence types yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is a bit misleading, no? We're not really simulating anything AFAICT. Yes, we generate some random genesis state, but that's not used for anything substantial in the state-machine apart from querying and varying state in DecodeStore
.
Until we have actual evidence we can submit and verify, I'd hold off in adding this module to simulation.
…os-sdk into fedekunze/5961-evidence-sims
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Added a few non-blocking nitpicks.
…os-sdk into fedekunze/5961-evidence-sims
* x/evidence: simulations * update app * evidence store decoder * add evidence to sim import export * fix test * prevent zero values on randomized genesis * return empty evidences for genesis state * address comments from review
Closes: #5961
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)