Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor simulation decoder #6037

Merged
merged 8 commits into from
Apr 21, 2020
Merged

Conversation

fedekunze
Copy link
Collaborator

Closes: #5664

Description

cc: @alexanderbez


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze added R4R and removed WIP labels Apr 21, 2020
@fedekunze fedekunze marked this pull request as ready for review April 21, 2020 17:34
@fedekunze fedekunze added the T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). label Apr 21, 2020
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #6037 into master will decrease coverage by 0.02%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master    #6037      +/-   ##
==========================================
- Coverage   54.65%   54.63%   -0.03%     
==========================================
  Files         424      424              
  Lines       25820    25834      +14     
==========================================
+ Hits        14113    14115       +2     
- Misses      10736    10742       +6     
- Partials      971      977       +6     

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez
Copy link
Contributor

There looks to be issues with the x/params decoder.

@fedekunze
Copy link
Collaborator Author

fedekunze commented Apr 21, 2020

@alexanderbez If you're ok, I'd suggest merging this since the bug is from #6002 and this PR's changes are unrelated

@fedekunze fedekunze requested a review from jgimeno April 21, 2020 21:11
@alexanderbez alexanderbez merged commit 3ee975c into master Apr 21, 2020
@alexanderbez alexanderbez deleted the fedekunze/5664-sim-decoder-refactor branch April 21, 2020 21:33
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Simulations T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simulation Decoder Refactor
2 participants