Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLI tests for fee deduction #6088

Merged
merged 64 commits into from
Apr 29, 2020
Merged

Add CLI tests for fee deduction #6088

merged 64 commits into from
Apr 29, 2020

Conversation

sahith-narahari
Copy link
Contributor

@sahith-narahari sahith-narahari commented Apr 27, 2020 •
edited
Loading

Reference - #5951

Description

This adds tests for recover keys and fee deduction in bank

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

sahith-narahari and others added 30 commits April 15, 2020 03:57
@sahith-narahari
Added cli integration base setup
014caf8
@sahith-narahari
Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…
a42c097 
…-cli-test
@sahith-narahari
Added cmd to simapp
df53367
@sahith-narahari
Fixed ci-lint issues
c2e22b9
@sahith-narahari
Fixed ci-lint issues
13b5531
@sahith-narahari
Addressed changes in Makefile
858e744
@sahith-narahari
Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…
0755f09 
…-cli-tests
@sahith-narahari
Updated simd to latest
0ae1966
@sahith-narahari
Removed testnet and replay commands
6f362fd
@sahith-narahari
Modified tx command for simcli
5136a91
@sahith-narahari
Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…
295b023 
…-cli-tests
@sahith-narahari
Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…
df2424a 
…-cli-tests
@sahith-narahari
Did code cleanup
da5b8e3
@sahith-narahari
Merge branch 'sahith/add-cli-tests' of github.com:regen-network/cosmo…
6e82b44 
…s-sdk into sahith/add-cli-test
@sahith-narahari
Removed duplication in Makefile
0ef94f2
@sahith-narahari
Refactored cli_test
6670f90
@sahith-narahari
Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…
e130c40 
…-base-setup
@sahith-narahari
Added build-sim to Makefile
bc88c76
@sahith-narahari
Added test-cli to circleci
baa4b60
@sahith-narahari
Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…
828092c 
…-base-setup
Added tests for staking txns
85fae47
@sahith-narahari
Addressed format issues
5d33cbd
@sahith-narahari
Merge branch 'sahith/add-staking-tests' of github.com:regen-network/c…
349e09d 
…osmos-sdk into atheesh/cli-test-send
refctored tests code
61b6692
@sahith-narahari
Added tests for send, staking
0258675
@sahith-narahari
Merge remote-tracking branch 'origin/atheesh/cli-test-send' into athe…
8815250 
…esh/cli-test-send

# Conflicts:
#	cli_test/tests/staking_test.go
@sahith-narahari
Removed test_hepers file
1b9c2ec
@sahith-narahari
Moved test_cover to contrib
3101ed3
@sahith-narahari
Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…
09efc33 
…-base-setup
Added codec in fixtures
93f1b09
@codecov
Copy link

codecov bot commented Apr 29, 2020 •
edited
Loading

Codecov Report

Merging #6088 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6088   +/-   ##
=======================================
  Coverage   54.78%   54.78%           
=======================================
  Files         437      437           
  Lines       26433    26433           
=======================================
  Hits        14482    14482           
  Misses      10955    10955           
  Partials      996      996

@sahith-narahari sahith-narahari marked this pull request as ready for review April 29, 2020 20:04
@aaronc aaronc changed the title Add tests for fee deduction Add CLI tests for fee deduction Apr 29, 2020
alexanderbez
alexanderbez approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alexanderbez alexanderbez added C:CLI R4R A:automerge Automatically merge PR once all prerequisites pass. labels Apr 29, 2020
aaronc
aaronc approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@mergify mergify bot merged commit b854c48 into cosmos:master Apr 29, 2020
@clevinson clevinson added this to the v0.39 milestone May 4, 2020
@ryanchristo ryanchristo deleted the sahith/add-fee-tests branch December 12, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronc aaronc aaronc approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio Awaiting requested review from alessio

@fedekunze fedekunze Awaiting requested review from fedekunze

@hschoenburg hschoenburg Awaiting requested review from hschoenburg

@nylira nylira Awaiting requested review from nylira

Assignees

@sahith-narahari sahith-narahari

Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI
Projects
None yet
Milestone
v0.40 [Stargate]
Development

Successfully merging this pull request may close these issues.
6 participants
@sahith-narahari @aaronc @alexanderbez @clevinson @kaustubhkapatral @anilcse