Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli tests for auth #6152

Merged
merged 9 commits into from
May 6, 2020

Conversation

sahith-narahari
Copy link
Contributor

@sahith-narahari sahith-narahari commented May 5, 2020

Description

Reference - #5951

@auto-comment
Copy link

auto-comment bot commented May 5, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Thank you for your contribution to the Cosmos-SDK! 🚀

@sahith-narahari sahith-narahari mentioned this pull request May 5, 2020
11 tasks
@sahith-narahari sahith-narahari marked this pull request as draft May 5, 2020 22:05
@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #6152 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6152   +/-   ##
=======================================
  Coverage   54.87%   54.87%           
=======================================
  Files         442      442           
  Lines       26627    26627           
=======================================
  Hits        14612    14612           
  Misses      11005    11005           
  Partials     1010     1010           

@sahith-narahari sahith-narahari marked this pull request as ready for review May 5, 2020 22:31
@alessio
Copy link
Contributor

alessio commented May 5, 2020

please merge master back in @sahith-narahari

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fedekunze fedekunze merged commit c211488 into cosmos:master May 6, 2020
@sahith-narahari sahith-narahari deleted the sahith/refactor-auth-tests branch May 15, 2020 12:15
@clevinson clevinson added this to the v0.39 milestone Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants