Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REST: Add 'max-body-bytes' Flag #6167

Merged
merged 3 commits into from
May 7, 2020
Merged

REST: Add 'max-body-bytes' Flag #6167

merged 3 commits into from
May 7, 2020

Conversation

alexanderbez
Copy link
Contributor

Description

Add max-body-bytes CLI flag to the REST service.

@alexanderbez alexanderbez added R4R A:automerge Automatically merge PR once all prerequisites pass. labels May 7, 2020
@alexanderbez alexanderbez self-assigned this May 7, 2020
@auto-comment
Copy link

auto-comment bot commented May 7, 2020 •
edited by alexanderbez
Loading

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Thank you for your contribution to the Cosmos-SDK! 🚀

@alexanderbez alexanderbez requested a review from tac0turtle May 7, 2020 17:25
alessio
alessio reviewed May 7, 2020
View reviewed changes
client/flags/flags.go Outdated Show resolved Hide resolved
alessio
alessio approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot merged commit fe9fe87 into master May 7, 2020
@mergify mergify bot deleted the bez/rpc-max-body-bytes-cfg branch May 7, 2020 17:49
@Itchibon777 Itchibon777 mentioned this pull request Jan 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@alessio alessio alessio approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@clevinson clevinson Awaiting requested review from clevinson

@hschoenburg hschoenburg Awaiting requested review from hschoenburg

@nylira nylira Awaiting requested review from nylira

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees

@alexanderbez alexanderbez

Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexanderbez @alessio @fedekunze