Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify AppModule #6231

Merged
merged 25 commits into from
Jun 10, 2020
Merged

simplify AppModule #6231

merged 25 commits into from
Jun 10, 2020

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented May 15, 2020 •
edited
Loading

Description

closes: #6232

@auto-comment
Copy link

auto-comment bot commented May 15, 2020 •
edited by jgimeno
Loading

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Thank you for your contribution to the Cosmos-SDK! 🚀

@jgimeno jgimeno changed the title Just a test, not review Concept PR simplify Module May 15, 2020
@jgimeno jgimeno mentioned this pull request May 15, 2020
Closed
4 tasks
@jgimeno jgimeno added the WIP label May 18, 2020
@codecov
Copy link

codecov bot commented May 18, 2020 •
edited
Loading

Codecov Report

Merging #6231 into master will decrease coverage by 0.02%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #6231      +/-   ##
==========================================
- Coverage   55.53%   55.50%   -0.03%     
==========================================
  Files         464      465       +1     
  Lines       27549    27536      -13     
==========================================
- Hits        15299    15284      -15     
- Misses      11152    11154       +2     
  Partials     1098     1098

alessio
alessio reviewed Jun 10, 2020
View reviewed changes
types/router.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Jun 10, 2020
View reviewed changes
types/router.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Jun 10, 2020
View reviewed changes
types/router.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Jun 10, 2020
View reviewed changes
types/router.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Jun 10, 2020
View reviewed changes
types/router.go Outdated Show resolved Hide resolved
alessio
alessio reviewed Jun 10, 2020
View reviewed changes
types/router.go Outdated Show resolved Hide resolved
@jgimeno jgimeno marked this pull request as ready for review June 10, 2020 15:59
@jgimeno jgimeno added R4R and removed WIP labels Jun 10, 2020
alexanderbez
alexanderbez reviewed Jun 10, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great to me! I left a comment on the general approach.

types/router.go Outdated
Route(ctx Context, path string) Handler
}

// Route represents a Route used by the Router.
type Route interface {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why make this an interface and not just expose the concrete type? Do we plan on having multiple implementations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexanderbez it is funny because when I was reviewing the code I just thought the same as you and I was very close to make it concrete.

So this confirms it, I will change it. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, good work!

fedekunze
fedekunze approved these changes Jun 10, 2020
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Agree with @alexanderbez comment

@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 10, 2020
fedekunze
fedekunze reviewed Jun 10, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
alexanderbez
alexanderbez approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Great work @jgimeno

@mergify mergify bot merged commit 79c308a into master Jun 10, 2020
@mergify mergify bot deleted the jonathan/module-avoid-route-name branch June 10, 2020 18:48
@jgimeno jgimeno mentioned this pull request Jun 11, 2020
Merged
8 tasks
@alessio alessio changed the title Concept PR simplify Module simplify AppModule Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio alessio alessio left review comments

@fedekunze fedekunze fedekunze approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@clevinson clevinson Awaiting requested review from clevinson

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Simplification of AppModule interface.
4 participants
@jgimeno @alessio @alexanderbez @fedekunze