-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simapp Localnet #6421
Simapp Localnet #6421
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6421 +/- ##
=======================================
Coverage 55.66% 55.66%
=======================================
Files 465 465
Lines 27674 27674
=======================================
Hits 15404 15404
Misses 11169 11169
Partials 1101 1101 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, would we want to publish a docker image somewhere?
Why? This is just a simapp used for local testing and integration purposes. |
@alexanderbez just curious, is there a reason we couldn't also do this by spinning off sub-processes instead of docker compose? It seems that would be more portable for other apps. We could have a |
There are many many ways you can do this. This has existed before I worked on the SDK and I just simply replicated the process because it works and is simple. I will note that I generally am in favor of Docker (compose) and would prefer to stay that route. App devs can implement this however they wish. The SDK doesn't aim to provide devops tooling. |
I agree with this. |
* Setup localnet * Fix compose * Fix file perms * Fix build * Codec + lint updates * lint++
Description
Drop-n-lift localnet functionality from Gaia. So we no longer have to rely on Gaia.
closes: #6418
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer